fix: preserve streamed output guardrail tripwires in the run loop#2758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a streamed output-guardrail regression where
Runner.run_streamed()could swallowOutputGuardrailTripwireTriggereduntilstream_events()was consumed, allowing callers that awaitrun_loop_taskdirectly to observe a completed run withfinal_outputset. It updates the streaming run loop to re-raise output-guardrail tripwires and cancellation, while avoiding the generic agent-span error path so the existing guardrail-specific tracing remains intact.It also adds a regression test that exercises the non-
stream_events()path by awaitingrun_loop_taskdirectly and asserting that the tripwire is surfaced immediately and the final output is not finalized. This keeps the fix aligned with the real repro instead of only covering the already-tested event-consumption path.